nonsensical-dev/zenyx-engine
nonsensical-dev/zenyx-engine
3
0
Fork 1
Code Issues 6 Pull requests 2 Projects 1 Releases Activity Actions

feat(ecs): add rudimentary sparse set impl #5

Manually merged
bitsyndicate merged 2 commits from sparse-sets into main 2025-04-20 22:08:54 +00:00
Conversation 4 Commits 2 Files changed 5 +279
bitsyndicate commented 2025-04-20 21:55:45 +00:00
Owner
Copy link

Closes #2

Closes #2
bitsyndicate added this to the ECS milestone 2025-04-20 21:55:45 +00:00
bitsyndicate added the
Priority
High
Kind/Feature
Testing
Required
 labels 2025-04-20 21:55:45 +00:00
bitsyndicate self-assigned this 2025-04-20 21:55:45 +00:00
bitsyndicate added 1 commit 2025-04-20 21:55:45 +00:00
feat(ecs): add rudimentary sparse set impl
Some checks failed
Build Zenyx ⚡ / 🏗️ Build x86_64-unknown-linux-gnu (push) Has been skipped
Details
Build Zenyx ⚡ / 🏗️ Build x86_64-pc-windows-msvc (push) Has been skipped
Details
Build Zenyx ⚡ / 🔧 Setup Environment (push) Failing after 53s
Details
Build Zenyx ⚡ / 🏗️ Build aarch64-unknown-linux-gnu (push) Has been skipped
Details
Build Zenyx ⚡ / 🔧 Setup Environment (pull_request) Failing after 54s
Details
Build Zenyx ⚡ / 🏗️ Build x86_64-pc-windows-msvc (pull_request) Has been skipped
Details
Build Zenyx ⚡ / 🏗️ Build aarch64-unknown-linux-gnu (pull_request) Has been skipped
Details
Build Zenyx ⚡ / 🏗️ Build x86_64-unknown-linux-gnu (pull_request) Has been skipped
Details
11774c227a
bitsyndicate added this to the Zenyx project 2025-04-20 21:55:46 +00:00
requested reviews from lily, caznix 2025-04-20 21:56:13 +00:00
caznix approved these changes 2025-04-20 22:01:42 +00:00
Dismissed
lily requested changes 2025-04-20 22:04:14 +00:00
Dismissed
src/collections/sparse_set.rs Outdated
@ -0,0 +129,4 @@
Some(previous)
}
pub fn is_emtpy(&self) -> bool {
lily commented 2025-04-20 22:03:19 +00:00
Owner
Copy link

Misspelled function name

Misspelled function name
bitsyndicate marked this conversation as resolved
bitsyndicate added 1 commit 2025-04-20 22:05:51 +00:00
chore: fix typo in function name
Some checks failed
Build Zenyx ⚡ / 🏗️ Build x86_64-unknown-linux-gnu (push) Has been skipped
Details
Build Zenyx ⚡ / 🏗️ Build x86_64-pc-windows-msvc (push) Has been skipped
Details
Build Zenyx ⚡ / 🏗️ Build aarch64-unknown-linux-gnu (push) Has been skipped
Details
Build Zenyx ⚡ / 🔧 Setup Environment (pull_request) Failing after 53s
Details
Build Zenyx ⚡ / 🏗️ Build aarch64-unknown-linux-gnu (pull_request) Has been skipped
Details
Build Zenyx ⚡ / 🏗️ Build x86_64-unknown-linux-gnu (pull_request) Has been skipped
Details
Build Zenyx ⚡ / 🏗️ Build x86_64-pc-windows-msvc (pull_request) Has been skipped
Details
Build Zenyx ⚡ / 🔧 Setup Environment (push) Failing after 57s
Details
6166925d39
bitsyndicate dismissed caznix's review 2025-04-20 22:05:51 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

requested reviews from lily, caznix 2025-04-20 22:05:58 +00:00
caznix approved these changes 2025-04-20 22:06:44 +00:00
lily approved these changes 2025-04-20 22:06:54 +00:00
bitsyndicate removed the
Testing
Required
 label 2025-04-20 22:06:58 +00:00
bitsyndicate referenced this pull request from a commit 2025-04-20 22:08:53 +00:00
Merge branch 'sparse-sets' (#5)
bitsyndicate manually merged commit bba64d2fb9 into main 2025-04-20 22:08:54 +00:00
lily referenced this pull request from a commit 2025-04-21 22:48:25 +00:00
Merge branch 'sparse-sets' (#5)
bitsyndicate referenced this pull request from a commit 2025-04-22 18:37:26 +00:00
Merge branch 'sparse-sets' (#5)
bitsyndicate referenced this pull request from a commit 2025-04-22 19:07:15 +00:00
Merge branch 'sparse-sets' (#5)
bitsyndicate referenced this pull request from a commit 2025-04-22 19:59:25 +00:00
Merge branch 'sparse-sets' (#5)
Sign in to join this conversation.
Reviewers
No reviewers
caznix
lily
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Discussion

Discuss details of a future endeavour

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Platform
All
Applies to all platforms

  
Platform
Android
Applies to Android only

  
Platform
IOS
Applies to IOS only

  
Platform
Linux
Applies to Linux only

  
Platform
MacOS
Applies to macOS only

  
Platform
Mobile
Applies to Mobile platforms only (Android & IOS)

  
Platform
UNIX
Applies to UNIX based platforms (Linux & MacOS)

  
Platform
Web
Applies to WASM only

  
Platform
Windows
Applies to Windows only

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Testing
Not needed
Testing is not required to merge this issue

  
Testing
Required
Testing is needed to merge this issue

No labels
Compat/Breaking
Kind/Bug
Kind/Discussion
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Platform
All
Platform
Android
Platform
IOS
Platform
Linux
Platform
MacOS
Platform
Mobile
Platform
UNIX
Platform
Web
Platform
Windows
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Testing
Not needed
Testing
Required
Milestone
Clear milestone
No items
No milestone
ECS
Projects
Clear projects
No items
No project
Zenyx
Assignees
Clear assignees
No assignees
bitsyndicate
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: nonsensical-dev/zenyx-engine#5
No description provided.
Delete branch "sparse-sets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?